Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capability for admins to answer to close comments #75

Closed
wants to merge 20 commits into from

Conversation

ElviaBth
Copy link
Collaborator

@ElviaBth ElviaBth commented Jun 17, 2024

🎩 What? Why?

This PR enables administrators to answer comments or post new ones even after they are closed to participants.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

📷 Screenshots

image
warning message for blocked comments

♥️ Thank you!

andreslucena and others added 15 commits May 22, 2024 16:04
This is done mainly because some modules (such as Initiatives) don't
have the feature for blocking the comments in the steps (as they don't
have steps as a Participatory Process)
* Add link to Attachment and allow adding and updating the link from the admin panel

* Move migration to decidim-participatory_processes engine

* Add I18n and simplify dual display for Attachment with/without link

* Normalise locales

* Fix updating an attachments

* Fix attachment update logic

* Fix update_attachment specs

* Hide download button for Attachment links

* Update guidelines for Attachment Link tab

* Add specific tests for attachment with_link

* Add js to enable/disable the tabs in the attachment form

* Add visit link button for link attachments

* Update attachment content type for linked documents

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Add docs to file or link tabs js file

* Fix tab panels cell inside forms

* Rename attachments panel tab file

* Add test for link attachment

* Remove markup reference from js docs

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

---------

Co-authored-by: Eduardo Martinez Echevarria <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
* Do not allow registering to a meeting if it started

* Fix spec

* Add spec with the behavior change

* Fix rubocop offense
…dim#12846)

* Add a check in system for the secret key

* Add a check in system for the ActiveJob queue

* Refactor the UI to keep it DRY

* Fix a bug when the secret_key is nil

* Open external URL in a new tab

Suggested in code review

* Use remixicon from redesign in system panel

* Fix rubocop offense

* Fix erblint offense
* Change default proposal sorting word to automatic

* Fix specs

Suggested in code review
* Define resource permission of meetings to reply polls

* Add poll answers view including polling behavior

* Add back to meeting link

* Add permission to update polls questions in front

* Add endpoint to admin questions in polls

* Disable reply poll button if poll has no questions

* Add unanswered scope to questions

* Remove polls from live event page

* Move reply poll button

* Change editable method of questionnaire and define one for question form

* Do not delete answers after updating questionnaire

* Prevent update of questions not editable

* Allow edition of questions of questionnaire

* Change class of not editable questions to avoid js updates

* Add announcement to poll edition in admin

* Add locked icon to not editable questions

* desktop version

* Allow edition of questionnaire questions always

* Allow replying meeting polls when questions are present

* mobile version

* fix styles

* Update titles

* fix label_tag

* Simplify single option form

* Change class of not editable questions max choices to avoid js updates

* Allow changing position of not editable questions of questionnaire

* Provide all associated values of not editable questions in forms to avoid blank data if validation fails

* Add comment

* Update polling feature

* Recover questionStatuses storage

* Simplify multiple_option answers interface

* Add max choices to validation error message

* Provide edit in admin button on questions unpublished from administration page and display status

* Include a link from admin to administrate poll questions

* Update button

* Change announcement content

* Add a button to administrate poll in meeting aside if admin is not allowed to reply

* Use action_authorized_link_to in reply poll from administrate page

* Fix linter offenses

* Remove class in use from list of deprecated

* Remove unused translation

* Add questions statuses translations to ignore unused list

* Add missing quotes

* Change poll button text when all questions are closed

* Remove useless method

The value of this method has been set to true always so it's not
required

* Open admin edition of poll in new window from poll administrate

* Adapt test to administrate poll questions

* Adapt test to reply poll questions

* Remove unused factory

* Add sleep in example

* Allow reordering not editable questions in admin

* Update admin manages meetings in polls examples

* Improve tests of reply poll

* Add examples to check the status display of questions in administrate

* Display poll actions buttons in meeting show in different place depending on mobile

* Add sleep

* Memoize method

* Change selector to display validation error message

* Update id of multiple choices to avoid duplications

* Change title of questions to include max choices data if present

* Update config/i18n-tasks.yml

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

* Remove reference to polls in live event meeting embed type description

* Replace selectors to use data attributes

---------

Co-authored-by: Hugoren Martinako <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
…2) (decidim#12951)

* updated delegation to form. Refactored join_meeting but failing on user symbol

* user: not being recognized

* controller concern fix

* fixed join_meeting_spec file called user: current_user

* .merge added to create method to form in controller

* test for merge params

* error in syntax

* Revert "test for merge params"

This reverts commit 695bdab.

* reverting commit

* current_user assigned create method in registrations controller

* removing commented out code

* changes based on Andres' review

* Update join_meeting.rb

Co-authored-by: Andrés Pereira de Lucena <[email protected]>

---------

Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@ElviaBth ElviaBth closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants